FAILED: 21.5.26 build with MSVC++ 2008 Starter edition

[Aidan Kehoe]

Hi Robert --

I’ve committed part of your patch, modified slightly to reflect the
environment variables available to me:

http://mid.gmane.org/E1Jytgc-0002zM-6b@alioth.debian.org

The auto-generated Win32 intl code is incomplete for me, even with that
change, so I didn’t commit it--looks like we need to work out accurate
minimum specifications for the Windows compiler. 

A question; what did this part of your patch do exactly? 

diff -r c32b3d10c56b nt/xemacs.mak
--- a/nt/xemacs.mak	Sat Apr 26 16:28:44 2008 +0200
+++ b/nt/xemacs.mak	Wed May 14 10:02:09 2008 +0200
@@ -794,7 +794,7 @@ INCLUDES=-I$(NT)\inc -I$(SRC) $(OPT_INCL
 INCLUDES=-I$(NT)\inc -I$(SRC) $(OPT_INCLUDES)
 
 DEFINES=$(OPT_DEFINES) \
-	-DWIN32_LEAN_AND_MEAN -DWIN32_NATIVE -Demacs \
+	-DWIN32_LEAN_AND_MEAN -DWIN32_NATIVE -Demacs -DNTDDI_VERSION=NTDDI_WIN2K -D_WIN32_WINNT=_WIN32_WINNT_WIN2K \
 	-DHAVE_CONFIG_H $(PROGRAM_DEFINES) $(PATH_DEFINES)
 
 CFLAGS_NO_OPT=-nologo -W3 -DSTRICT $(DEBUG_FLAGS_COMPILE)

Bye, 

Aidan

 Ar an ceathrú lá déag de mí Bealtaine, scríobh Robert Pluim: 

 > On Sat, May 10, 2008 at 8:36 AM, Stephen J. Turnbull <stephen at xemacs.org>
 > wrote:
 > 
 > > Matthew Persico writes:
 > >
 > >  > Now I am left with this:
 > >  >
 > >  > c:\opt\xemacs\src\xemacs-21.5.28\src\intl-auto-encap-win32.h(80) :
 > >  > error C2061: syntax error : identifier 'LPSHQUERYRBINFO'
 > >  >
 > >  > The code in question is this:
 > >  >
 > >  > HRESULT qxeSHQueryRecycleBin (const Extbyte * pszRootPath,
 > >  > LPSHQUERYRBINFO pSHQueryRBInfo);
 > >
 > >  > Twenty lines later we have these two lines, which seem to be happy:
 > >
 > > How do you know they're happy?  Many compilers will crap out on the
 > > first error and stop there.
 > >
 > > To test that you could just comment out line 80.
 > >
 > > Are you sure that the relevant part of ShellAPI.h is being included?
 > > Maybe there's a conditional.  Or maybe somehow ShellAPI.h itself is
 > > not getting included.
 > >
 > > I don't know how to check those on Windows, though.
 > >
 > 
 > I've attached a diff of what I did to get this to work a while back.
 > Basically it looks like the defines needed by the windows  header files have
 > changed.
 > 
 > Let's hope gmail doesn't mangle the attachment.
 > 
 > Robert

-- 
¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir
precipitadamente de la aldea por culpa de la escasez de rinocerontes?