auctex: to submit or not to submit that is the question.

Stephen J. Turnbull stephen at xemacs.org
Mon Apr 7 17:55:50 EDT 2008


Uwe Brauer writes:

 > I therefore propose to apply the XEmacs.rules patch *before* I
 > submit.

We cannot review the XEmacs.rules patch without seeing the code that
it is intended to support.  It is almost as important to keep unneeded
cruft out of the codebase as it is to add needed features.  So you are
saying we should apply an unreviewed patch.  That's not right; we
wouldn't do it for any other maintainer, either.

I've looked at the auto-autoload.el diff and do not understand why
achieving this effect needs changes to XEmacs.rules.  The review is
made more difficult because it appears that the diff is reversed, and
there are other changes besides those that would be explained by the
patch to XEmacs.rules (of course I can't be sure of that because I
don't have access to the code that generates the difference).

BTW, most XEmacs reviewers prefer "diff -u" as the format for
differences.  (Put the line "diff -u" in ~/.cvsrc on Unix systems to
have cvs diff use that format automatically.  There should be a
similar feature for Windows.)

So *please* commit the AUCTeX changes (on a branch is very safe), or
post a tarball of the source tree on a website, or something, so we
can evaluate the need for these changes to XEmacs.rules.

To make a branch in CVS, in the xemacs-packages/auctex directory from
XEmacs CVS, do

cvs tag -b -r auctex-1_48 auctex-11_84-import        # a known branch point

# In a new workspace do:
cvs checkout -r auctex-11_84-import

# From now on you cannot do any harm to the files that Norbert works
# with.
# We assume a ls(1) that supports -A and -R, the sort(1) and uniq(1)
# utilities.
ls -AR > OLD-MANIFEST

# update the AUCTeX tree to the content you want it to have
ls -AR > NEW-MANIFEST

# get information about added, removed, and renamed files
cat OLD-MANIFEST NEW-MANIFEST | sort | uniq -d > SAME-MANIFEST
cat SAME-MANIFEST NEW-MANIFEST | sort | uniq -u > ADDS-MANIFEST
cat OLD-MANIFEST SAME-MANIFEST | sort | uniq -u > REMOVES-MANIFEST

# First, check that the file lists in ADDS-MANIFEST and
# REMOVES-MANIFEST are sane!  Then you can do:
cvs remove `cat REMOVES-MANIFEST`
cvs add `cat ADDS-MANIFEST`
rm *-MANIFEST                # assumes AUCTeX has no *-MANIFEST file!
cvs commit -m "Current state of AUCTeX 11.84 import to XEmacs."

and tell us the branch tag (in the example above, it's
"auctex-11_84-import").



More information about the XEmacs-Beta mailing list