[PATCH] package sh-script executable.el (executable-interpret): parameter correction

[Jerry James]

On Sat, Mar 15, 2008 at 2:37 AM, It's me FKtPp ;) <m_pupil at yahoo.com.cn> wrote:
> Dear Reviewers,
>
>  Do you think the following changelog and patch are acceptable to be
>  commited?
>
>  ChangeLog addition:
>
>  2008-03-15  It's me FKtPp ;)  <m_pupil at yahoo.com.cn>
>
>     * executable.el (executable-interpret): Correct compile-internal's
>     parameters to avoid error when `C-c C-x'(executable-interpret).
>
>
>  sh-script[Packages] source patch:
>  Diff command:   cvs -q diff -u
>  Files affected: executable.el
>  ===================================================================
>  RCS
>
>  Index: executable.el
>  ===================================================================
>  RCS file:
>  /pack/xemacscvs/XEmacs/packages/xemacs-packages/sh-script/executable.el,v
>  retrieving revision 1.4
>  diff -u -r1.4 executable.el
>  --- executable.el    2005/10/15 21:27:07    1.4
>  +++ executable.el    2008/03/15 08:26:22
>  @@ -223,9 +223,12 @@
>    (save-some-buffers (not compilation-ask-about-save))
>    (set (make-local-variable 'executable-command) command)
>    (let ((compilation-error-regexp-alist executable-error-regexp-alist))
>  -    (compile-internal command t (lambda (x) "*interpretation*"))))
>  -
>  -
>  +    (compile-internal command
>  +              "No More Errors"
>  +              nil
>  +              nil
>  +              nil
>  +              (lambda (x) "*interpretation*"))))
>
>   ;;;###autoload
>   (defun executable-set-magic (interpreter &optional argument

Make the string "No more errors" instead.  Also, could you insert a
comment just above the compile-internal invocation stating something
like this:

;; XEmacs change: arguments to compile-internal differ from Emacs

That way we we're less likely to lose your fix on the next sync with
Emacs.  Thanks for catching this!
-- 
Jerry James
http://loganjerry.googlepages.com/