[Bug: 21.5-b28] Bug in #'loop

[Stephen J. Turnbull]

Aidan Kehoe writes:

 > Here's a tentative fix that I have yet to test in detail; the
 > SXEmacs folk and Sebastian in particular have a pretty
 > comprehensive test suite available, though, and I intend to get to
 > testing it soon.

Please import the test suite into our regression tests.

 > --- cl-macs.el~	Mon Jan  7 17:35:10 2008
 > +++ cl-macs.el	Mon Jan  7 17:37:58 2008
 > @@ -1183,1 +1183,1 @@
 > -		  (push (list 'consp temp) loop-body)
 > +		  (push temp loop-body)

I've checked the HyperSpec and the expansion of the test form.  (I
wish you would take these obvious steps *and* document them when
submitting a patch like this.)  This looks like it is correct FWIW.

However you should also fix the doc to warn that (a) it will signal an
error if the LIST is a dotted list, (b) it will infloop (and crash if
the body conses) if the LIST is a circular list, and (c) even if it
errors, side effects may be executed.

There are also a bunch of typos in the doc that you might want to fix
up while you're there.