How to suppress environment variable expansion by find-file?

[Michael Sperber]

"Adrian Aichner" <adrian at xemacs.org> writes:

> Right, Skip!
>
> By sheer coincidence I have partially tracked down a variation on the
> theme today.
>
> I access files on administrative shares under windows, or should I
> say, I used to :-)
>
> Paths of the pattern
> \\COMPUTER\DRIVE$\FILE
> trigger the same problem.
>
> I can do dired, using
> \\COMPUTER\DRIVE$$
> which evaluates to
> \\COMPUTER\DRIVE$
> but opening FILE will evaluate C$ once more and fall over.
>
> The difference is that insert-file-contents in 21.5 epands the file
> argument using substitute-in-file-name, which the 21.4 variant did not
> use to.
>
> Michael Sperber should know more about this.
>
> Mike?

Yo.  It was me.  Sorry.  I just copied the call to
`substitute-in-file-name' from somewhere else, and I believe it's just
as incorrect there.  So how about this?

2008-01-04  Michael Sperber  <mike at xemacs.org>

	* code-files.el (insert-file-contents):
	(load): Don't call `substitute-in-file-name' on the file name.

-- 
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
-------------- next part --------------
diff --git a/lisp/code-files.el b/lisp/code-files.el
--- a/lisp/code-files.el
+++ b/lisp/code-files.el
@@ -235,10 +235,10 @@ object (the entry specified a coding sys
 
 ;(defun convert-mbox-coding-system (filename visit start end) ...)
 
-(defun load (file &optional noerror nomessage nosuffix)
-  "Execute a file of Lisp code named FILE, or load a binary module.
-First tries to find a Lisp FILE with .elc appended, then with .el, then with
- FILE unmodified.  If unsuccessful, tries to find a binary module FILE with
+(defun load (filename &optional noerror nomessage nosuffix)
+  "Execute a file of Lisp code named FILENAME, or load a binary module.
+First tries to find a Lisp file FILENAME with .elc appended, then with .el, then with
+ FILENAME unmodified.  If unsuccessful, tries to find a binary module FILE with
  the elements of `module-extensions' appended, one at a time.
 Searches directories in load-path for Lisp files, and in `module-load-path'
  for binary modules.
@@ -250,9 +250,8 @@ If optional fourth arg NOSUFFIX is non-n
  .elc, .el, or elements of `module-extensions' to the specified name FILE.
 Return t if file exists."
   (declare (special load-modules-quietly))
-  (let* ((filename (substitute-in-file-name file))
-	 (handler (find-file-name-handler filename 'load))
-	 (path nil))
+  (let ((handler (find-file-name-handler filename 'load))
+	(path nil))
     (if handler
 	(funcall handler 'load filename noerror nomessage nosuffix)
       ;; First try to load a Lisp file
@@ -262,10 +261,10 @@ Return t if file exists."
 					    '(".elc" ".el" "")))))
 	  ;; now use the internal load to actually load the file.
 	  (load-internal
-	   file noerror nomessage nosuffix
+	   filename noerror nomessage nosuffix
 	   (let ((elc ; use string= instead of string-match to keep match-data.
-		(equalp ".elc" (substring path -4))))
-	     (or (and (not elc) coding-system-for-read) ;prefer for source file
+		  (equalp ".elc" (substring path -4))))
+	     (or (and (not elc) coding-system-for-read)	;prefer for source file
 		 ;; find magic-cookie
 		 (let ((codesys
 			(find-coding-system-magic-cookie-in-file path)))
@@ -401,8 +400,7 @@ See also `insert-file-contents-access-ho
 See also `insert-file-contents-access-hook',
 `insert-file-contents-pre-hook', `insert-file-contents-error-hook',
 and `insert-file-contents-post-hook'."
-  (let* ((expanded (substitute-in-file-name filename))
-	 (handler (find-file-name-handler expanded 'insert-file-contents)))
+  (let ((handler (find-file-name-handler filename 'insert-file-contents)))
     (if handler
 	(funcall handler 'insert-file-contents filename visit start end replace)
       (let (return-val coding-system used-codesys)