patch: wrong property list

Aidan Kehoe kehoea at parhasard.net
Tue Jan 1 10:27:40 EST 2008


Jeff, you’re listed as the package maintainer. Could you take a look at this
thread? See http://thread.gmane.org/gmane.emacs.xemacs.beta/26548 . Note
that I say in a followup that (:weight bold) doesn’t work, so it needs to be
(:bold t) . 

 Ar an chéad lá is fiche de mí na Nollaig, scríobh Mike FABIAN: 

 > In some face definitions in the “calendar” package I found properties like
 > 
 >    (:weight bold t)
 > 
 > which is most likely wrong, probably it should be just
 > 
 >    (:weight bold)
 > 
 > otherwise it is not a correct plist, is it?
 > 
 > In most other packages
 > 
 >    (:bold t)
 > 
 > is used, maybe “(:weight bold)” is obsolete anyway?
 > 
 > A tentative patch is attached.
 > 
 > -- 
 > Mike FABIAN   <mfabian at suse.de>   http://www.suse.de/~mfabian
 > 睡眠不足はいい仕事の敵だ。
 > I � Unicode
 > 
 > diff -ru packages.orig/xemacs-packages/calendar/calendar.el packages/xemacs-packages/calendar/calendar.el
 > --- packages.orig/xemacs-packages/calendar/calendar.el	2007-07-16 12:11:09.000000000 +0200
 > +++ packages/xemacs-packages/calendar/calendar.el	2007-12-21 19:35:51.000000000 +0100
 > @@ -191,7 +191,7 @@
 >      (((class color) (background dark))
 >       (:foreground "yellow"))
 >      (t
 > -     (:weight bold t)))
 > +     (:weight bold)))
 >    "Face for highlighting diary entries."
 >    :group 'diary)
 >  ;; backward-compatibility alias
 > diff -ru packages.orig/xemacs-packages/calendar/diary-lib.el packages/xemacs-packages/calendar/diary-lib.el
 > --- packages.orig/xemacs-packages/calendar/diary-lib.el	2007-07-16 12:11:09.000000000 +0200
 > +++ packages/xemacs-packages/calendar/diary-lib.el	2007-12-21 19:35:42.000000000 +0100
 > @@ -1956,7 +1956,7 @@
 >      (((class color) (background dark))
 >       (:foreground "cyan"))
 >      (t
 > -     (:weight bold t)))
 > +     (:weight bold)))
 >    "Face used for anniversaries in the diary."
 >    :group 'diary)
 >  
 > @@ -1967,7 +1967,7 @@
 >      (((class color) (background dark))
 >       (:foreground "cyan3"))
 >      (t
 > -     (:weight bold t)))
 > +     (:weight bold)))
 >    "Face used for times of day in the diary."
 >    :group 'diary)
 >  
 > diff -ru packages.orig/xemacs-packages/perl-modes/cperl-mode.el packages/xemacs-packages/perl-modes/cperl-mode.el
 > --- packages.orig/xemacs-packages/perl-modes/cperl-mode.el	2006-06-28 17:27:40.000000000 +0200
 > +++ packages/xemacs-packages/perl-modes/cperl-mode.el	2007-12-21 19:36:58.000000000 +0100
 > @@ -1087,7 +1087,7 @@
 >  ;;; `cperl-under-as-char'  is nil in RMS.
 >  ;;; Minor differences in docstrings, and `cperl-non-problems'.
 >  ;;; Backward compatibility addressed: (`); (function (lambda ...)); font-lock;
 > -;;; (:italic t bold t) vs (:slant italic :weight bold) in faces;
 > +;;; (:italic t :bold t) vs (:slant italic :weight bold) in faces;
 >  ;;; `normal-auto-fill-function'.
 >  ;;; RMS version has wrong logic in `cperl-calculate-indent': $a = { } is
 >  ;;; wrongly indented if the closing brace is on a separate line.
 > _______________________________________________
 > XEmacs-Beta mailing list
 > XEmacs-Beta at xemacs.org
 > http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta

-- 
¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir
precipitadamente de la aldea por culpa de la escasez de rinocerontes?



More information about the XEmacs-Beta mailing list