[PATCH] Abstract out a display-table-specific API (2)

Mike Kupfer m.kupfer at acm.org
Tue Dec 25 01:06:05 EST 2007


>>>>> "Aidan" == Aidan Kehoe <kehoea at parhasard.net> writes:

MikeK> Second, you appear to be introducing multiple copies of
MikeK> put-display-table and get-display-table, both in this patch set and
MikeK> in the patches you committed to xemacs-base and misc-games.
MikeK> Shouldn't there be just one copy in the packages tree, presumably in
MikeK> xemacs-base?

Aidan> disp-table.el, which provides the display table
Aidan> code--make-display-table, frob-display-table,
Aidan> describe-display-table, and in
Aidan> http://mid.gmane.org/18288.1954.87217.762309@parhasard.net ,
Aidan> put-display-table and get-display-table--is in core. Yeah,
Aidan> there's a decent argument that it might be better in packages,
Aidan> but it isn't there for the moment. 

I'm not sure we're understanding each other.  I can understand having
the functions in core in 21.5, plus a version in packages using
defun-when-void for 21.4.  What I'm saying is that there should only be
*one* copy in packages, for use by all the packages.  But your patches
introduce duplicates in gnus, xemacs-base, misc-games, etc.  Instead,
put one copy in xemacs-base (case-table.el?  new file?), and all the
other packages can use that copy, yeah?

mike



More information about the XEmacs-Beta mailing list