21.5 Windows jpeg patch

[Ron Isaacson]

Aidan Kehoe wrote:
> 
>  Ar an séiú lá de mí na Nollaig, scríobh Ron Isaacson:
> 
>  > So I just built 21.5.28 for Windows, and noticed that jpeg glyphs fail
>  > with this error:
>  >
>  >   JPEG parameter struct mismatch: library thinks size is xx, caller
>  >   expects yy
>  >
>  > Google found several hits, including many on libtiff-related lists
>  > that offer the same fix. A patch is attached. (One such message is
>  > referenced in the patch. I can't take credit for the actual fix, just
>  > the Google->XEmacs transform.)
> 
> Okay, I don't actually see the problem locally, but the patch seems sensible
> enough and it doesn't break the build or anything of the sort, so I've gone
> ahead and committed it. What exactly are the versions of the various
> libraries that break for you?

Here are all of the external libs I'm using -- each is a local build
from source:

  xpm  -> 3.4k
  png  -> 1.2.8
  zlib -> 1.2.3
  jpeg -> 6b.3
  tiff -> 3.7.2

I read that this can happen if there's a mismatch between the
build-time and runtime versions of libjpeg, although on Windows
everything is static, so that shouldn't be an issue, right?

I can reproduce this using:

  (glyph-image-instance
    (make-glyph [jpeg :file "c:/any/image.jpg"]))

Without the patch, it always fails with the error message above.

--
Ron Isaacson
Morgan Stanley
ron.isaacson at morganstanley.com / (212) 276-1144