Pushing new vc towards regular packages tree
Ville Skyttä
scop at xemacs.org
Thu Sep 6 13:17:52 EDT 2007
On Monday 20 August 2007, Michael Albinus wrote:
>
> > Can't say for certain offhand, but comments slightly above the line you
> > patched include:
> >
> > ;; The following defadvice is no longer necessary after changes in VC
> > ;; on 2006-01-25, Andre.
> > [...]
> > ;; With Emacs 22, the definition of `vc-user-login-name' has been
> > ;; changed. It doesn't need to be adviced any longer.
> >
> > ...so I suppose the whole (defadvice vc-user-login-name) no longer
> > applies to the new vc.
>
> Yes, indeed.
>
> > If it's not needed, perhaps there's a way to detect it and skip the
> > code altogether? There's already a (unless (fboundp 'process-file))
> > around it, but perhaps that's for some other purpose?
>
> (fboundp 'process-file) is a check for "GNU Emacs 22 existence", because
> it is a new function introduced there. Implicitely, it means "new vc
> existence". If there is a better check for the existence of "new vc", we
> should apply that instead.
I think checking (fboundp 'vc-find-version) would be better. It exists in the
XEmacs "new vc" as well as in the one in GNU Emacs 22, but does not exist in
the XEmacs "old vc" nor in the GNU Emacs 21.3 one:
http://cvs.savannah.gnu.org/viewvc/emacs/lisp/vc.el?root=emacs&view=diff&r1=1.311.4.9%3AEMACS_21_3&tr1=1.311.4.9&r2=1.424%3AEMACS_22_1&tr2=1.1&diff_format=h
Patch attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tramp-new-vc.patch
Type: text/x-diff
Size: 659 bytes
Desc: not available
Url : http://lists.xemacs.org/pipermail/xemacs-beta/attachments/20070906/8def7506/tramp-new-vc.patch
More information about the XEmacs-Beta
mailing list