Patch: fix cut & past problem on 64 bit platforms

[Takashi Iwai]

At Sat, 17 Feb 2007 14:09:51 +0900,
Stephen J. Turnbull wrote:
> 
> Mike FABIAN writes:
> 
>  > Patch by Takashi IWAI and me.
> 
> Thanks for the patch!
> 
>  > For details please have a look at
>  > 
>  > http://bugzilla.novell.com/show_bug.cgi?id=244613
> 
> (1) As I understand it the crash is presumably caused by a buffer
> overrun overwriting the stack, not in the codec trying to decode a
> corrupt (truncated) selection string, right?  Ie, the problem leading
> to a crash has been fixed here, it's not something in the codec that
> is masked by giving it uncorrupt data?
 
Yes, it was just a mistake in my patches.  The last patch in the above
is correct and doesn't lead to crashes.

I misunderstood X*Property() API as if they return the real byte
length.  The API returns, however, the size of bytes in the assumption
of data witdth = 32bit (as format = 32).

> (2) Now, this looks like a bug in the 64-bit X libraries to me.  What
> happens if it gets fixed?

It's no implementation bug but a brain-dead API definition.


Takashi