[Q21.4] Avoid a crash in Cygwin when clicking File -> Print under
Win32
Vin Shelton
acs at xemacs.org
Fri Dec 8 23:58:18 EST 2006
QUERY
On 11/29/06, Aidan Kehoe <kehoea at parhasard.net> wrote:
>
> Ar an t-ochtú lá is fiche de mí na Samhain, scríobh Dr. Volker Zell:
>
> > Aidan, can we install this patch for 21.4 and 21.5 ? It seems to do the
> > right thing.
>
> It's Vin's call as to whether it goes into 21.4, but I see no reason for it
> not to.
>
> APPROVE COMMIT 21.5, RECOMMEND 21.4.
>
> NOTE: This patch has been committed.
>
> src/ChangeLog addition:
>
> 2006-11-29 Aidan Kehoe <kehoea at parhasard.net>
>
> * sound.c (init_native_sound):
> Only X11 and GTK devices can possibly not be on the console of the
> associated machine. Fixes a crash when init_native_sound is called
> on a msprinter device.
>
>
> XEmacs Trunk source patch:
> Diff command: cvs -q diff -Nu
> Files affected: src/sound.c
> ===================================================================
> RCS
>
> Index: src/sound.c
> ===================================================================
> RCS file: /pack/xemacscvs/XEmacs/xemacs/src/sound.c,v
> retrieving revision 1.27
> diff -u -u -r1.27 sound.c
> --- src/sound.c 2006/07/11 23:40:17 1.27
> +++ src/sound.c 2006/11/29 19:06:06
> @@ -590,7 +590,7 @@
> static void
> init_native_sound (struct device *d)
> {
> - if (DEVICE_TTY_P (d) || DEVICE_STREAM_P (d) || DEVICE_MSWINDOWS_P(d))
> + if (!(DEVICE_X_P(d) || DEVICE_GTK_P(dev)))
I don't know much about this part of the code (or anything about gtk),
but what is dev? If I got the regexp syntax correct, this is the only
occurance in the source file.
- Vin
--
The Journey by Mary Oliver
http://www.poemhunter.com/p/m/poem.asp?poet=6771&poem=30506
More information about the XEmacs-Beta
mailing list