[Patch 21.4] native cygwin xemacs-21.4.19 segfaults when requiring un-define

[Stephen J. Turnbull]

>>>>> "vin" == Vin Shelton <acs at xemacs.org> writes:

    vin> Does anyone think the below patch will have a noticeable
    vin> effect on the speed byte compiler?

I imagine it will be *measurable* (eg, by profiling the
byte-compilation phase of a build) but probably not noticable.

    vin> Barring any concerns, I will check this in for 21.4.20.

The main concern I have is that Aidan admits that the code hasn't been
audited for memory leaks, which is always a concern when moving from
alloca (which is effectively garbage-collected by the stack
discipline) to malloc.  OTOH, byte-compilation is a very rare event;
any leaks probably will not be noticable.

Probably running a full compile with XEmacs instrumented by valgrind
or similar would catch almost all problems.


-- 
School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba                    Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
               Ask not how you can "do" free software business;
              ask what your business can "do for" free software.