Beta test a new comint.el

[Jerry James]

Hi Jeff,

Jeff Mincy <jeff at delphioutpost.com> wrote:
> On Tue, 02 May 2006, james at xemacs.org wrote:
>
>> Beta testers wanted!
>> 
>> I started work on syncing us up with Emacs comint.el ... oh, I don't
>> remember now.  It was quite a long time ago, though.  Anyway, I have had
>> a candidate sync for a couple of weeks now.  I've been using it myself,
>> but my typical patterns of use only exercise a small part of it.  I've
>> been deliberately using features I don't normally use, but I would feel
>> better about it if a few other people gave it a try.  I'll attach it to
>> this message.
>> Thanks in advance for any feedback.
>
> M-x shell in shell.el calls make-comint-1 which is no longer defined
> in your comint.el.

I had nuking make-comint-1 on my list of things to do, and managed to
check it off without fixing its use in shell.el.  Thanks for catching
that.  I'll double-check that I haven't done that with any other
functions.  I think this will be the appropriate fix for shell.el:

Index: shell.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/xemacs-base/shell.el,v
retrieving revision 1.13
diff -d -u -r1.13 shell.el
--- shell.el	2006/05/08 05:40:58	1.13
+++ shell.el	2006/05/08 22:40:23
@@ -653,8 +653,8 @@
 		  (xargs-name (intern-soft (concat "explicit-" name "-args"))))
 	     (if (not (file-exists-p startfile))
 		 (setq startfile (concat "~/.emacs.d/.emacs_" name)))
-	     (setq buffer (set-buffer (apply 'make-comint-1 buffer
-					     prog
+	     (setq buffer (set-buffer (apply #'make-comint-in-buffer "shell"
+					     buffer prog
 					     (if (file-exists-p startfile)
 						 startfile)
 					     (if (and xargs-name


> Did you sync other comint derived files?

No, but (except for make-comint-1 obviously) I have been grepping for
uses of changed/deleted functions in comint.el in both core and
packages.
-- 
Jerry James, Assistant Professor        james at xemacs.org
Computer Science Department             http://www.cs.usu.edu/~jerry/
Utah State University