bug: "edmacro" is *always* autoloaded which causes annoying messages

Zajcev Evgeny zevlg at yandex.ru
Sat Apr 1 11:49:13 EST 2006


Mike FABIAN <mfabian at suse.de> writes:

[..]
>> Therefore edmacro.el is loaded if it is not already there.  And this
>> causes the messages about loading "edmacro":
>> 
>>     mfabian at shannon:~$ xemacs -nw -q -vanilla -kill
>> 
>>     Loading edmacro...
>>     Loading edmacro...done
>> 
>>     mfabian at shannon:~$
>> 
[..]
>
> diff -ru packages.orig/xemacs-packages/xwem/lisp/xwem-clgen.el packages/xemacs-packages/xwem/lisp/xwem-clgen.el
> --- packages.orig/xemacs-packages/xwem/lisp/xwem-clgen.el	2005-04-04 21:54:10.000000000 +0200
> +++ packages/xemacs-packages/xwem/lisp/xwem-clgen.el	2006-03-30 17:46:08.000000000 +0200
> @@ -95,7 +95,6 @@
>  
>  ;;; Internal variables
>  
> -;;;###autoload
>  (defvar xwem-clgen-map 
>    (let ((map (make-sparse-keymap)))
>      (define-key map (kbd "H-c H-o") 'xwem-clgen-toggle-other-on-split)

Yes, this patch is ok, this autoload is invalid at all .. and even
call to `kbd' is not qite correct, it should call `xwem-kbd' instead,
so code

    ;;;###autoload
    (defvar xwem-clgen-map 
      (let ((map (make-sparse-keymap)))
        (define-key map (kbd "H-c H-o") 'xwem-clgen-toggle-other-on-split)
    ...

should look like

    (defvar xwem-clgen-map 
      (let ((map (make-sparse-keymap)))
        (define-key map (xwem-kbd "H-c H-o") 'xwem-clgen-toggle-other-on-split)
    ...

And in the replying Stephen, yes we ought to use autoloading mechanism
for inter communication, however intercommunication part is hidden
from user in xwem-loaddefs.el file which loads only uppon loading xwem
.. xwem-loaddefs.el was created to avoid console messages(as above)
which causes `un`handling problems to Windows users.  Those particular
problem with `xwem-clgen-map' magically past through ..

Thanks for the notice Mike!  I will commit the patch ..

-- 
lg




More information about the XEmacs-Beta mailing list